mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-16 02:01:18 -04:00
Code Issues Packages Projects Releases Wiki Activity

jfs: avoid -Wtautological-constant-out-of-range-compare warning again

Browse Source 
The comparison of an __s8 value against DTPAGEMAXSLOT is still trivially
true, causing a harmless (default disabled) warning with clang:

fs/jfs/jfs_dtree.c:4419:25: error: result of comparison of constant 128 with expression of type 's8' (aka 'signed char') is always false [-Werror,-Wtautological-constant-out-of-range-compare]
 4419 |                                         p->header.freelist >= DTPAGEMAXSLOT)) {
      |                                         ~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~

I previously worked around two of these in commit 7833570dae ("jfs: avoid
-Wtautological-constant-out-of-range-compare warning"), but now a new one has
come up, so address the same way by dropping the redundant range check.

Fixes: 119e448bb5 ("jfs: add dtpage integrity check to prevent index/pointer overflows")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
This commit is contained in:
Arnd Bergmann
2026-03-16 15:42:51 +01:00
committed by Dave Kleikamp
parent 679330e4a7
commit dad98c5b2a
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
fs/jfs/jfs_dtree.c
View File

@@ -4412,11 +4412,8 @@ bool check_dtpage(dtpage_t *p)
}
} else {
int fsi;
/* When there are free slots, freelist must be a valid slot index in
* 1~DTROOTMAXSLOT-1(since slot[0] is occupied by the header).
*/
if (unlikely(p->header.freelist < 1 ||
p->header.freelist >= DTPAGEMAXSLOT)) {
if (unlikely(p->header.freelist < 1)) {
jfs_err("Bad freelist:%d in dtpage\n", p->header.freelist);
return false;
}