mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-08-29 11:37:59 -04:00
Code Issues Packages Projects Releases Wiki Activity

perf trace: Format instruction pointer fields as hexadecimal

Browse Source 
Provide a helper function trace__field_is_ip() in
trace__fprintf_tp_fields() to ensure that tracepoint fields representing
instruction pointers such as "__probe_ip", "caller_ip", and
"call_site" are always formatted as hexadecimal memory addresses rather
than signed integers.

For example, when running a kmem:kfree tracepoint:

    # perf trace --show-cpu --event kmem:kfree --max-event 1

    Before this change, "call_site" was represented as a signed integer:
      0.000 [003] xfce4-terminal/2201 kmem:kfree(call_site: -1714572588, ptr: 0xffff8afee0303000)

    After this change, "call_site" is correctly represented in hexadecimal:
      0.000 [003] xfce4-terminal/2201 kmem:kfree(call_site: 0xffffffff99cf1194, ptr: 0xffff8afee0303000)

This improves the readability of perf trace output by making code
addresses straightforward to parse and map to kernel symbols.

Signed-off-by: Aaron Tomlin <atomlin@atomlin.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
This commit is contained in:
Aaron Tomlin
2026-07-19 15:10:00 -04:00
committed by Namhyung Kim
parent ab74d1fbe0
commit da85966dfd
1 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
tools/perf/builtin-trace.c
View File

@@ -3224,6 +3224,13 @@ static unsigned char bitmap_byte(const unsigned long *mask, int byte_idx)
return b_val;
}
static bool trace__field_is_ip(const char *name)
{
return !strcmp(name, "__probe_ip") ||
!strcmp(name, "caller_ip") ||
!strcmp(name, "call_site");
}
static size_t trace__fprintf_tp_fields(struct trace *trace, struct perf_sample *sample,
struct thread *thread, void *augmented_args, int augmented_args_size)
{
@@ -3236,6 +3243,7 @@ static size_t trace__fprintf_tp_fields(struct trace *trace, struct perf_sample *
size_t printed = 0, btf_printed;
unsigned long val;
u8 bit = 1;
bool is_probe_ip;
struct syscall_arg syscall_arg = {
.augmented = {
.size = augmented_args_size,
@@ -3323,9 +3331,14 @@ static size_t trace__fprintf_tp_fields(struct trace *trace, struct perf_sample *
* Suppress it by default to avoid cluttering the output.
* If verbose mode is enabled, ensure it is formatted as a
* hexadecimal memory address rather than a signed integer.
*
* caller_ip and call_site are also expected to be instruction
* pointers and should always be represented in hexadecimal.
*/
if (evsel__is_probe(evsel) && !strcmp(field->name, "__probe_ip")) {
if (!verbose)
is_probe_ip = evsel__is_probe(evsel) && !strcmp(field->name, "__probe_ip");
if (is_probe_ip || trace__field_is_ip(field->name)) {
if (is_probe_ip && !verbose)
continue;
printed += scnprintf(bf + printed, size - printed,