mirrors/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-04 04:28:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

[media] staging: atomisp: Ignore errors from second gpio in ov2680 driver

Browse Source 
As the existing comment in the driver indicates the sensor has only 1 pin,
but some boards may have 2 gpios defined and we toggle both as we we don't
know which one is the right one. However if the ACPI resources table
defines only 1 gpio (as expected) the gpio1_ctrl call will always fail,
causing the probing of the driver to file.

This commit ignore the return value of the gpio1_ctrl call, fixing this.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
Hans de Goede
2017-05-28 09:31:52 -03:00
committed by Mauro Carvalho Chehab
parent 22b2807dae
commit da3e18059b
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/staging/media/atomisp/i2c/ov2680.c
View File

@@ -885,11 +885,12 @@ static int gpio_ctrl(struct v4l2_subdev *sd, bool flag)
if (flag) {
ret = dev->platform_data->gpio0_ctrl(sd, 1);
usleep_range(10000, 15000);
ret |= dev->platform_data->gpio1_ctrl(sd, 1);
/* Ignore return from second gpio, it may not be there */
dev->platform_data->gpio1_ctrl(sd, 1);
usleep_range(10000, 15000);
} else {
ret = dev->platform_data->gpio1_ctrl(sd, 0);
ret |= dev->platform_data->gpio0_ctrl(sd, 0);
dev->platform_data->gpio1_ctrl(sd, 0);
ret = dev->platform_data->gpio0_ctrl(sd, 0);
}
return ret;
}