mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-14 17:06:24 -04:00
Code Issues Packages Projects Releases Wiki Activity

smb: client: remove useless smbd_connection.send_immediate

Browse Source 
We always set it to true before having an if statement that checks it is
true...

Cc: Steve French <smfrench@gmail.com>
Cc: Tom Talpey <tom@talpey.com>
Cc: Long Li <longli@microsoft.com>
Cc: linux-cifs@vger.kernel.org
Cc: samba-technical@lists.samba.org
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
This commit is contained in:
Stefan Metzmacher
2025-08-14 18:34:02 +02:00
committed by Steve French
parent c7316ec2d5
commit d3e743b514
2 changed files with 2 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
fs/smb/client/smbdirect.c
View File

@@ -563,14 +563,10 @@ static void smbd_post_send_credits(struct work_struct *work)
}
/* Promptly send an immediate packet as defined in [MS-SMBD] 3.1.1.1 */
info->send_immediate = true;
if (atomic_read(&sc->recv_io.credits.count) <
sc->recv_io.credits.target - 1) {
if (info->keep_alive_requested == KEEP_ALIVE_PENDING ||
info->send_immediate) {
log_keep_alive(INFO, "send an empty message\n");
smbd_post_send_empty(info);
}
log_keep_alive(INFO, "send an empty message\n");
smbd_post_send_empty(info);
}
}
@@ -1124,8 +1120,6 @@ static int smbd_post_send_iter(struct smbd_connection *info,
atomic_add(new_credits, &sc->recv_io.credits.count);
packet->credits_granted = cpu_to_le16(new_credits);
info->send_immediate = false;
packet->flags = 0;
if (manage_keep_alive_before_sending(info))
packet->flags |= cpu_to_le16(SMBDIRECT_FLAG_RESPONSE_REQUESTED);

2
fs/smb/client/smbdirect.h
View File

@@ -74,8 +74,6 @@ struct smbd_connection {
/* Used by transport to wait until all MRs are returned */
wait_queue_head_t wait_for_mr_cleanup;
bool send_immediate;
struct workqueue_struct *workqueue;
struct delayed_work idle_timer_work;