mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-09 17:17:04 -04:00
Code Issues Packages Projects Releases Wiki Activity

media: i2c: ds90ub913: Add error handling to ub913_log_status()

Browse Source 
Add error handling to ub913_log_status().

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
This commit is contained in:
Tomi Valkeinen
2025-03-03 21:32:10 +05:30
committed by Hans Verkuil
parent fe591fb5ed
commit d3be2fcde6
1 changed files with 25 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
drivers/media/i2c/ds90ub913.c
View File

@@ -504,25 +504,41 @@ static int ub913_log_status(struct v4l2_subdev *sd)
{
struct ub913_data *priv = sd_to_ub913(sd);
struct device *dev = &priv->client->dev;
u8 v = 0, v1 = 0, v2 = 0;
u8 v, v1, v2;
int ret;
ret = ub913_read(priv, UB913_REG_MODE_SEL, &v, NULL);
if (ret)
return ret;
ub913_read(priv, UB913_REG_MODE_SEL, &v, NULL);
dev_info(dev, "MODE_SEL %#02x\n", v);
ub913_read(priv, UB913_REG_CRC_ERRORS_LSB, &v1, NULL);
ub913_read(priv, UB913_REG_CRC_ERRORS_MSB, &v2, NULL);
ub913_read(priv, UB913_REG_CRC_ERRORS_LSB, &v1, &ret);
ub913_read(priv, UB913_REG_CRC_ERRORS_MSB, &v2, &ret);
if (ret)
return ret;
dev_info(dev, "CRC errors %u\n", v1 | (v2 << 8));
/* clear CRC errors */
ub913_read(priv, UB913_REG_GENERAL_CFG, &v, NULL);
ub913_read(priv, UB913_REG_GENERAL_CFG, &v, &ret);
ub913_write(priv, UB913_REG_GENERAL_CFG,
v | UB913_REG_GENERAL_CFG_CRC_ERR_RESET, NULL);
ub913_write(priv, UB913_REG_GENERAL_CFG, v, NULL);
v | UB913_REG_GENERAL_CFG_CRC_ERR_RESET, &ret);
ub913_write(priv, UB913_REG_GENERAL_CFG, v, &ret);
if (ret)
return ret;
ret = ub913_read(priv, UB913_REG_GENERAL_STATUS, &v, NULL);
if (ret)
return ret;
ub913_read(priv, UB913_REG_GENERAL_STATUS, &v, NULL);
dev_info(dev, "GENERAL_STATUS %#02x\n", v);
ub913_read(priv, UB913_REG_PLL_OVR, &v, NULL);
ret = ub913_read(priv, UB913_REG_PLL_OVR, &v, NULL);
if (ret)
return ret;
dev_info(dev, "PLL_OVR %#02x\n", v);
return 0;