mirrors/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-04-22 15:06:18 -04:00
Code Issues Packages Projects Releases Wiki Activity

net/fungible: Fix local_memory_node error

Browse Source 
Stephen Rothwell reported the following failure on powerpc:

ERROR: modpost: ".local_memory_node"
[drivers/net/ethernet/fungible/funeth/funeth.ko] undefined!

AFAICS this is because local_memory_node() is a non-inline non-exported
function when CONFIG_HAVE_MEMORYLESS_NODES=y. It is also the wrong API
to get a CPU's memory node. Use cpu_to_mem() in the two spots it's used.

Fixes: ee6373ddf3 ("net/funeth: probing and netdev ops")
Fixes: db37bc177d ("net/funeth: add the data path")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Dimitris Michailidis <dmichail@fungible.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Dimitris Michailidis
2022-03-07 20:53:21 -08:00
committed by David S. Miller
parent 1330b6ef33
commit cdba24904e
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ethernet/fungible/funeth/funeth_main.c
View File

@@ -253,7 +253,7 @@ static struct fun_irq *fun_alloc_qirq(struct funeth_priv *fp, unsigned int idx,
int cpu, res;
cpu = cpumask_local_spread(idx, node);
node = local_memory_node(cpu_to_node(cpu));
node = cpu_to_mem(cpu);
irq = kzalloc_node(sizeof(*irq), GFP_KERNEL, node);
if (!irq)

2
drivers/net/ethernet/fungible/funeth/funeth_txrx.h
View File

@@ -239,7 +239,7 @@ static inline void fun_txq_wr_db(const struct funeth_txq *q)
static inline int fun_irq_node(const struct fun_irq *p)
{
return local_memory_node(cpu_to_node(cpumask_first(&p->affinity_mask)));
return cpu_to_mem(cpumask_first(&p->affinity_mask));
}
int fun_rxq_napi_poll(struct napi_struct *napi, int budget);