mirrors/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-02-23 21:11:51 -05:00
Code Issues Packages Projects Releases Wiki Activity

staging: gpib: replace dump function by print_hex_dump

Browse Source 
It is better to use a standard (proven in use) in-kernel function that does
the same. This also solves two buffer overflow problems.

Signed-off-by: Kees Bakker <kees@ijzerbout.nl>
Link: https://lore.kernel.org/r/20241017191433.2E7BD18DAFE@bout3.ijzerbout.nl
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Kees Bakker
2024-10-17 21:13:31 +02:00
committed by Greg Kroah-Hartman
parent 0edaa545af
commit cbf821e689
2 changed files with 2 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/staging/gpib/agilent_82357a/agilent_82357a.c
View File

@@ -208,20 +208,8 @@ static int agilent_82357a_receive_control_msg(struct agilent_82357a_priv *a_priv
static void agilent_82357a_dump_raw_block(const u8 *raw_data, int length)
{
#define RAW_BUF_SIZE 256
int i, pos = 0;
char print_buf[RAW_BUF_SIZE];
pr_info("hex block dump\n");
for (i = 0; i < length; ++i) {
if (i && (i % 8 == 0)) {
pr_info("%s\n", print_buf);
pos = 0;
}
pos += snprintf(&print_buf[pos], RAW_BUF_SIZE, " %02x", raw_data[i]);
}
if (pos)
pr_info("%s\n", print_buf);
print_hex_dump(KERN_INFO, "", DUMP_PREFIX_NONE, 8, 1, raw_data, length, true);
}
static int agilent_82357a_write_registers(struct agilent_82357a_priv *a_priv,

14
drivers/staging/gpib/ni_usb/ni_usb_gpib.c
View File

@@ -355,20 +355,8 @@ static int ni_usb_parse_status_block(const u8 *buffer, struct ni_usb_status_bloc
static void ni_usb_dump_raw_block(const u8 *raw_data, int length)
{
#define RAW_BUF_SIZE 256
int i, pos = 0;
char print_buf[RAW_BUF_SIZE];
pr_info("hex block dump\n");
for (i = 0; i < length; ++i) {
if (i && (i % 8 == 0)) {
pr_info("%s\n", print_buf);
pos = 0;
}
pos += snprintf(&print_buf[pos], RAW_BUF_SIZE, " %02x", raw_data[i]);
}
if (pos)
pr_info("%s\n", print_buf);
print_hex_dump(KERN_INFO, "", DUMP_PREFIX_NONE, 8, 1, raw_data, length, true);
}
static int ni_usb_parse_register_read_block(const u8 *raw_data, unsigned int *results,