mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-08-31 03:35:32 -04:00
Code Issues Packages Projects Releases Wiki Activity

hwrng: drivers - Remove redundant dev_err()/dev_err_probe()

Browse Source 
Since commit 55b48e23f5 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() and dev_err_probe() calls.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Pan Chuang
2026-07-10 18:53:06 +08:00
committed by Herbert Xu
parent 3ae59a2eba
commit cad76142aa
6 changed files with 6 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/char/hw_random/airoha-trng.c
View File

@@ -187,10 +187,8 @@ static int airoha_trng_probe(struct platform_device *pdev)
airoha_trng_irq_mask(trng);
ret = devm_request_irq(&pdev->dev, irq, airoha_trng_irq, 0,
pdev->name, (void *)trng);
if (ret) {
dev_err(dev, "Can't get interrupt working.\n");
if (ret)
return ret;
}
init_completion(&trng->rng_op_done);

2
drivers/char/hw_random/cctrng.c
View File

@@ -509,7 +509,7 @@ static int cctrng_probe(struct platform_device *pdev)
/* register the driver isr function */
rc = devm_request_irq(dev, irq, cc_isr, IRQF_SHARED, "cctrng", drvdata);
if (rc)
return dev_err_probe(dev, rc, "Could not register to interrupt %d\n", irq);
return rc;
dev_dbg(dev, "Registered to IRQ: %d\n", irq);
/* Clear all pending interrupts */

2
drivers/char/hw_random/imx-rngc.c
View File

@@ -297,7 +297,7 @@ static int __init imx_rngc_probe(struct platform_device *pdev)
irq, imx_rngc_irq, 0, pdev->name, (void *)rngc);
if (ret) {
clk_disable_unprepare(rngc->clk);
return dev_err_probe(&pdev->dev, ret, "Can't get interrupt working.\n");
return ret;
}
if (self_test) {

3
drivers/char/hw_random/jh7110-trng.c
View File

@@ -303,8 +303,7 @@ static int starfive_trng_probe(struct platform_device *pdev)
ret = devm_request_irq(&pdev->dev, irq, starfive_trng_irq, 0, pdev->name,
(void *)trng);
if (ret)
return dev_err_probe(&pdev->dev, ret,
"Failed to register interrupt handler\n");
return ret;
trng->hclk = devm_clk_get(&pdev->dev, "hclk");
if (IS_ERR(trng->hclk))

5
drivers/char/hw_random/omap-rng.c
View File

@@ -391,11 +391,8 @@ static int of_get_omap_rng_device_details(struct omap_rng_dev *priv,
err = devm_request_irq(dev, irq, omap4_rng_irq,
IRQF_TRIGGER_NONE, dev_name(dev), priv);
if (err) {
dev_err(dev, "unable to request irq %d, err = %d\n",
irq, err);
if (err)
return err;
}
/*
* On OMAP4, enabling the shutdown_oflo interrupt is

2
drivers/char/hw_random/xgene-rng.c
View File

@@ -337,7 +337,7 @@ static int xgene_rng_probe(struct platform_device *pdev)
rc = devm_request_irq(&pdev->dev, ctx->irq, xgene_rng_irq_handler, 0,
dev_name(&pdev->dev), ctx);
if (rc)
return dev_err_probe(&pdev->dev, rc, "Could not request RNG alarm IRQ\n");
return rc;
/* Enable IP clock */
clk = devm_clk_get_optional_enabled(&pdev->dev, NULL);