media: i2c: mt9p031: Check return value of devm_gpiod_get_optional() in mt9p031_probe()

The devm_gpiod_get_optional() function may return an error pointer
(ERR_PTR) in case of a genuine failure during GPIO acquisition, not just
NULL which indicates the legitimate absence of an optional GPIO.

Add an IS_ERR() check after the function call to catch such errors and
propagate them to the probe function, ensuring the driver fails to load
safely rather than proceeding with an invalid pointer.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
Chen Ni
2026-02-02 10:43:12 +08:00
committed by Mauro Carvalho Chehab
parent 943b1f27a3
commit c8e0585dce

View File

@@ -1183,6 +1183,10 @@ static int mt9p031_probe(struct i2c_client *client)
mt9p031->reset = devm_gpiod_get_optional(&client->dev, "reset",
GPIOD_OUT_HIGH);
if (IS_ERR(mt9p031->reset)) {
ret = PTR_ERR(mt9p031->reset);
goto done;
}
ret = mt9p031_clk_setup(mt9p031);
if (ret)