perf annotate: Use zfree() to reduce chances of use after free

Do defensive programming by using zfree() to initialize freed pointers
to NULL, so that eventual use after free result in a NULL pointer deref
instead of more subtle behaviour.

Also include the missing linux/zalloc.h header directive.

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Arnaldo Carvalho de Melo
2023-04-12 09:50:08 -03:00
parent 25feb605fe
commit c77ceb2eb0

View File

@@ -38,6 +38,7 @@
#include <linux/bitops.h>
#include <linux/kernel.h>
#include <linux/string.h>
#include <linux/zalloc.h>
#include <subcmd/parse-options.h>
#include <subcmd/run-command.h>
@@ -1881,7 +1882,7 @@ symbol__disassemble_bpf_image(struct symbol *sym,
if (dl)
annotation_line__add(&dl->al, &notes->src->source);
free(args->line);
zfree(&args->line);
return 0;
}