mirrors/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-04 04:28:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

greybus: raw: Use consistent label names in connection_init()

Browse Source 
Some of the labels are named based on what they are going to undo, while
others are based on where we failed in connection_init().

Follow only the first type of naming.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Viresh Kumar
2016-02-12 16:08:26 +05:30
committed by Greg Kroah-Hartman
parent 7d0493d191
commit c463593c3d
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/staging/greybus/raw.c
View File

@@ -174,21 +174,21 @@ static int gb_raw_connection_init(struct gb_connection *connection)
cdev_init(&raw->cdev, &raw_fops);
retval = cdev_add(&raw->cdev, raw->dev, 1);
if (retval)
goto error_cdev;
goto error_remove_ida;
raw->device = device_create(raw_class, &connection->bundle->dev,
raw->dev, raw, "gb!raw%d", minor);
if (IS_ERR(raw->device)) {
retval = PTR_ERR(raw->device);
goto error_device;
goto error_del_cdev;
}
return 0;
error_device:
error_del_cdev:
cdev_del(&raw->cdev);
error_cdev:
error_remove_ida:
ida_simple_remove(&minors, minor);
error_free: