mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-15 20:12:00 -04:00
Code Issues Packages Projects Releases Wiki Activity

iio: addac: ad74115: use new GPIO line value setter callbacks

Browse Source 
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Link: https://patch.msgid.link/20250409-gpiochip-set-rv-iio-v2-7-4b36428f39cb@linaro.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
Bartosz Golaszewski
2025-04-09 10:40:45 +02:00
committed by Jonathan Cameron
parent b8b3ea6429
commit c3c8492cec
1 changed files with 8 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/iio/addac/ad74115.c
View File

@@ -542,18 +542,16 @@ static int ad74115_gpio_get(struct gpio_chip *gc, unsigned int offset)
return FIELD_GET(AD74115_GPIO_CONFIG_GPI_DATA, val);
}
static void ad74115_gpio_set(struct gpio_chip *gc, unsigned int offset, int value)
static int ad74115_gpio_set(struct gpio_chip *gc, unsigned int offset,
int value)
{
struct ad74115_state *st = gpiochip_get_data(gc);
struct device *dev = &st->spi->dev;
int ret;
ret = regmap_update_bits(st->regmap, AD74115_GPIO_CONFIG_X_REG(offset),
AD74115_GPIO_CONFIG_GPO_DATA,
FIELD_PREP(AD74115_GPIO_CONFIG_GPO_DATA, value));
if (ret)
dev_err(dev, "Failed to set GPIO %u output value, err: %d\n",
offset, ret);
return regmap_update_bits(st->regmap,
AD74115_GPIO_CONFIG_X_REG(offset),
AD74115_GPIO_CONFIG_GPO_DATA,
FIELD_PREP(AD74115_GPIO_CONFIG_GPO_DATA,
value));
}
static int ad74115_set_comp_debounce(struct ad74115_state *st, unsigned int val)
@@ -1579,7 +1577,7 @@ static int ad74115_setup_gpio_chip(struct ad74115_state *st)
.direction_input = ad74115_gpio_direction_input,
.direction_output = ad74115_gpio_direction_output,
.get = ad74115_gpio_get,
.set = ad74115_gpio_set,
.set_rv = ad74115_gpio_set,
};
return devm_gpiochip_add_data(dev, &st->gc, st);