mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-07-22 03:27:30 -04:00
fbdev: tdfxfb: fix potential memory leak in tdfxfb_probe()
In tdfxfb_probe(), the memory allocated for modelist using
fb_videomode_to_modelist() when CONFIG_FB_3DFX_I2C is defined, is not
freed in the subsequent error paths.
Fix that by calling fb_destroy_modelist().
Fixes: 215059d242 ("tdfxfb: make use of DDC information about connected monitor")
Cc: stable@vger.kernel.org
Signed-off-by: Abdun Nihaal <nihaal@cse.iitm.ac.in>
Signed-off-by: Helge Deller <deller@gmx.de>
This commit is contained in:
committed by
Helge Deller
parent
3b0ed04bc8
commit
bb019d7553
@@ -1552,6 +1552,7 @@ static int tdfxfb_probe(struct pci_dev *pdev, const struct pci_device_id *id)
|
||||
|
||||
out_err_iobase:
|
||||
#ifdef CONFIG_FB_3DFX_I2C
|
||||
fb_destroy_modelist(&info->modelist);
|
||||
tdfxfb_delete_i2c_busses(default_par);
|
||||
#endif
|
||||
arch_phys_wc_del(default_par->wc_cookie);
|
||||
|
||||
Reference in New Issue
Block a user