mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-08-31 07:03:28 -04:00
Code Issues Packages Projects Releases Wiki Activity

drm/amd/display: Fix DP LT failure logging

Browse Source 
[Why/How]
The final DP LT failure meant to be logged as DC warning is skipped due
to a break statement above. Move logging up to make sure we don't miss
LT fail events.

Reviewed-by: George Shen <george.shen@amd.com>
Signed-off-by: Ilya Bakoulin <Ilya.Bakoulin@amd.com>
Signed-off-by: Wayne Lin <wayne.lin@amd.com>
Tested-by: Dan Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:
Ilya Bakoulin
2026-06-30 17:57:18 -04:00
committed by Alex Deucher
parent 6bfca93847
commit b1cb2fc140
1 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training.c
View File

@@ -1721,6 +1721,20 @@ bool perform_link_training_with_retries(
}
}
if (j == (attempts - 1)) {
DC_LOG_WARNING(
"%s: Link(%d) training attempt %u of %d failed @ rate(%d) x lane(%d) @ spread = %x : fail reason:(%d)\n",
__func__, link->link_index, (unsigned int)j + 1, attempts,
cur_link_settings.link_rate, cur_link_settings.lane_count,
cur_link_settings.link_spread, status);
} else {
DC_LOG_HW_LINK_TRAINING(
"%s: Link(%d) training attempt %u of %d failed @ rate(%d) x lane(%d) @ spread = %x : fail reason:(%d)\n",
__func__, link->link_index, (unsigned int)j + 1, attempts,
cur_link_settings.link_rate, cur_link_settings.lane_count,
cur_link_settings.link_spread, status);
}
fail_count++;
dp_trace_lt_fail_count_update(link, fail_count, false);
if (link->ep_type == DISPLAY_ENDPOINT_PHY) {
@@ -1740,20 +1754,6 @@ bool perform_link_training_with_retries(
do_fallback = false;
}
if (j == (attempts - 1)) {
DC_LOG_WARNING(
"%s: Link(%d) training attempt %u of %d failed @ rate(%d) x lane(%d) @ spread = %x : fail reason:(%d)\n",
__func__, link->link_index, (unsigned int)j + 1, attempts,
cur_link_settings.link_rate, cur_link_settings.lane_count,
cur_link_settings.link_spread, status);
} else {
DC_LOG_HW_LINK_TRAINING(
"%s: Link(%d) training attempt %u of %d failed @ rate(%d) x lane(%d) @ spread = %x : fail reason:(%d)\n",
__func__, link->link_index, (unsigned int)j + 1, attempts,
cur_link_settings.link_rate, cur_link_settings.lane_count,
cur_link_settings.link_spread, status);
}
dp_disable_link_phy(link, &pipe_ctx->link_res, signal);
/* Abort link training if failure due to sink being unplugged. */