mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-03-30 21:27:17 -04:00
crash_dump: constify struct configfs_item_operations and configfs_group_operations
'struct configfs_item_operations' and 'configfs_group_operations' are not modified in this driver. Constifying these structures moves some data to a read-only section, so increases overall security, especially when the structure holds some function pointers. On a x86_64, with allmodconfig, as an example: Before: ====== text data bss dec hex filename 16339 11001 384 27724 6c4c kernel/crash_dump_dm_crypt.o After: ===== text data bss dec hex filename 16499 10841 384 27724 6c4c kernel/crash_dump_dm_crypt.o Link: https://lkml.kernel.org/r/d046ee5666d2f6b1a48ca1a222dfbd2f7c44462f.1765735035.git.christophe.jaillet@wanadoo.fr Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-by: Coiby Xu <coxu@redhat.com> Tested-by: Coiby Xu <coxu@redhat.com> Cc: Baoquan He <bhe@redhat.com> Cc: Dave Young <dyoung@redhat.com> Cc: Vivek Goyal <vgoyal@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
committed by
Andrew Morton
parent
0319227099
commit
b11052be3e
@@ -223,7 +223,7 @@ static void config_key_release(struct config_item *item)
|
||||
key_count--;
|
||||
}
|
||||
|
||||
static struct configfs_item_operations config_key_item_ops = {
|
||||
static const struct configfs_item_operations config_key_item_ops = {
|
||||
.release = config_key_release,
|
||||
};
|
||||
|
||||
@@ -298,7 +298,7 @@ static struct configfs_attribute *config_keys_attrs[] = {
|
||||
* Note that, since no extra work is required on ->drop_item(),
|
||||
* no ->drop_item() is provided.
|
||||
*/
|
||||
static struct configfs_group_operations config_keys_group_ops = {
|
||||
static const struct configfs_group_operations config_keys_group_ops = {
|
||||
.make_item = config_keys_make_item,
|
||||
};
|
||||
|
||||
|
||||
Reference in New Issue
Block a user