mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-07-22 02:17:36 -04:00
Code Issues Packages Projects Releases Wiki Activity

firewire: core: refactor notification type determination after isoc resource management in cdev

Browse Source 
After managing the actual isochronous resources, there is
post-processing logic to determine what type of event should be
notified. However, there is room for improvement.

This commit refactors the logic.

Link: https://lore.kernel.org/r/20260501135823.241940-4-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
This commit is contained in:
Takashi Sakamoto
2026-05-01 22:58:22 +09:00
parent 92750bccf0
commit afa66eeb18
1 changed files with 17 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
drivers/firewire/core-cdev.c
View File

@@ -1390,20 +1390,27 @@ static void iso_resource_auto_work(struct work_struct *work)
}
}
if (todo == ISO_RES_AUTO_ALLOC && channel >= 0)
r->params.channels = 1ULL << channel;
if (todo == ISO_RES_AUTO_REALLOC && success)
goto out;
if (todo == ISO_RES_AUTO_ALLOC) {
e = r->e_alloc;
r->e_alloc = NULL;
} else {
if (todo == ISO_RES_AUTO_DEALLOC) {
free = true;
e = r->e_dealloc;
r->e_dealloc = NULL;
} else {
if (todo == ISO_RES_AUTO_REALLOC) {
if (success)
goto out;
// Notify the userspace client of the failure through a deallocation event.
e = r->e_dealloc;
r->e_dealloc = NULL;
} else {
if (channel >= 0)
r->params.channels = 1ULL << channel;
e = r->e_alloc;
r->e_alloc = NULL;
}
}
e->iso_resource.handle = r->resource.handle;
e->iso_resource.channel = channel;
e->iso_resource.bandwidth = bandwidth;