mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-08-31 01:11:51 -04:00
serial: qcom-geni: trace: Drop redundant len field from geni_serial_data
The dynamic array stored in the ring buffer already carries its own length in the array metadata. There is no need to also store it as a separate scalar field in the entry struct. Drop __field(unsigned int, len) and the corresponding __entry->len assignment, and use __get_dynamic_array_len(data) in the TP_printk for both the len=%u format argument and the __print_hex() size argument. This saves 4 bytes per event on the ring buffer. Signed-off-by: Praveen Talari <praveen.talari@oss.qualcomm.com> Suggested-by: Steven Rostedt <rostedt@goodmis.org> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Link: https://patch.msgid.link/20260615-add-tracepoints-for-qcom-geni-serial-v5-1-2efa4c97e0e2@oss.qualcomm.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
31e11af34e
commit
a9b2c446e3
@@ -97,18 +97,17 @@ DECLARE_EVENT_CLASS(geni_serial_data,
|
||||
TP_ARGS(dev, buf, len),
|
||||
|
||||
TP_STRUCT__entry(__string(name, dev_name(dev))
|
||||
__field(unsigned int, len)
|
||||
__dynamic_array(u8, data, len)
|
||||
),
|
||||
|
||||
TP_fast_assign(__assign_str(name);
|
||||
__entry->len = len;
|
||||
memcpy(__get_dynamic_array(data), buf, len);
|
||||
),
|
||||
|
||||
TP_printk("%s: len=%u data=%s",
|
||||
__get_str(name), __entry->len,
|
||||
__print_hex(__get_dynamic_array(data), __entry->len))
|
||||
__get_str(name), __get_dynamic_array_len(data),
|
||||
__print_hex(__get_dynamic_array(data),
|
||||
__get_dynamic_array_len(data)))
|
||||
);
|
||||
|
||||
DEFINE_EVENT(geni_serial_data, geni_serial_tx_data,
|
||||
|
||||
Reference in New Issue
Block a user