mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-05-01 01:14:19 -04:00
drm/i915/xelpg: Fix write to MTL_MCR_SELECTOR
A misplaced closing parenthesis caused the groupid/instanceid values to
be considered part of the ternary operator's condition instead of being
OR'd into the resulting value.
Fixes: f32898c94a ("drm/i915/xelpg: Add multicast steering")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Arun R Murthy <arun.r.murthy@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221019222437.3035182-1-matthew.d.roper@intel.com
This commit is contained in:
@@ -249,7 +249,7 @@ static u32 rw_with_mcr_steering_fw(struct intel_uncore *uncore,
|
||||
intel_uncore_write_fw(uncore, MTL_MCR_SELECTOR,
|
||||
REG_FIELD_PREP(MTL_MCR_GROUPID, group) |
|
||||
REG_FIELD_PREP(MTL_MCR_INSTANCEID, instance) |
|
||||
(rw_flag == FW_REG_READ) ? GEN11_MCR_MULTICAST : 0);
|
||||
(rw_flag == FW_REG_READ ? GEN11_MCR_MULTICAST : 0));
|
||||
} else if (GRAPHICS_VER(uncore->i915) >= 11) {
|
||||
mcr_mask = GEN11_MCR_SLICE_MASK | GEN11_MCR_SUBSLICE_MASK;
|
||||
mcr_ss = GEN11_MCR_SLICE(group) | GEN11_MCR_SUBSLICE(instance);
|
||||
|
||||
Reference in New Issue
Block a user