mirrors/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-05 20:33:49 -04:00
Code Issues Packages Projects Releases Wiki Activity

staging: comedi: amplc_dio200_common: prevent extra free_irq()

Browse Source 
`dio200_detach()` in "amplc_dio200.c" calls
`amplc_dio200_common_detach()` in "amplc_dio200_common.c", followed by
`comedi_legacy_detach()` in "../drivers.c".  Both of those functions
call `free_irq()` if `dev->irq` is non-zero.  The second call produces a
warning message because the handler has already been freed.  Prevent
that by setting `dev->irq = 0` in `amplc_dio200_common_detach()`.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Ian Abbott
2014-07-25 18:07:07 +01:00
committed by Greg Kroah-Hartman
parent a948318f70
commit a386149fb2
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/comedi/drivers/amplc_dio200_common.c
View File

@@ -1202,8 +1202,10 @@ void amplc_dio200_common_detach(struct comedi_device *dev)
if (!thisboard || !devpriv)
return;
if (dev->irq)
if (dev->irq) {
free_irq(dev->irq, dev);
dev->irq = 0;
}
}
EXPORT_SYMBOL_GPL(amplc_dio200_common_detach);