mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-16 10:11:38 -04:00
Code Issues Packages Projects Releases Wiki Activity

spi: pl022: update outdated references to pump_transfers()

Browse Source 
The pump_transfers tasklet was removed when the driver
switched to the SPI core message processing loop in commit
9b2ef250b3 ("spi: spl022: switch to use default
spi_transfer_one_message()").  The kdoc of
pl022_interrupt_handler() still describes the old flow: scheduling
the pump_transfers tasklet, calling giveback(), and flagging
STATE_ERROR — none of which exist in the current code.  Rewrite
the kdoc to reflect the current paths, which flag errors via
SPI_TRANS_FAIL_IO and call spi_finalize_current_transfer()
directly.

Assisted-by: unnamed:deepseek-v3.2 coccinelle
Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
Reviewed-by: Linus Walleij <linusw@kernel.org>
Link: https://patch.msgid.link/20260321105940.8143-1-kexinsun@smail.nju.edu.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Kexin Sun
2026-03-21 18:59:40 +08:00
committed by Mark Brown
parent 9861e15f63
commit a37fb5166b
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/spi/spi-pl022.c
View File

@@ -1127,11 +1127,11 @@ static inline void pl022_dma_remove(struct pl022 *pl022)
*
* This function handles interrupts generated for an interrupt based transfer.
* If a receive overrun (ROR) interrupt is there then we disable SSP, flag the
* current message's state as STATE_ERROR and schedule the tasklet
* pump_transfers which will do the postprocessing of the current message by
* calling giveback(). Otherwise it reads data from RX FIFO till there is no
* more data, and writes data in TX FIFO till it is not full. If we complete
* the transfer we move to the next transfer and schedule the tasklet.
* current transfer with SPI_TRANS_FAIL_IO and call
* spi_finalize_current_transfer() to let the core finish the message.
* Otherwise it reads data from RX FIFO till there is no more data, and writes
* data in TX FIFO till it is not full. When the transfer is complete we call
* spi_finalize_current_transfer() so the core can schedule the next one.
*/
static irqreturn_t pl022_interrupt_handler(int irq, void *dev_id)
{