mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-16 03:11:11 -04:00
Code Issues Packages Projects Releases Wiki Activity

USB: usbip: drop redundant device reference

Browse Source 
Driver core holds a reference to the USB device while it is bound to a
driver and there is no need to take additional references unless the
structure is needed after disconnect.

Drop the redundant device reference to reduce cargo culting, make it
easier to spot drivers where an extra reference is needed, and reduce
the risk of memory leaks when drivers fail to release it.

Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20260305133851.2952-3-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Johan Hovold
2026-03-05 14:38:51 +01:00
committed by Greg Kroah-Hartman
parent 0888c3371a
commit a1678c4e57
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/usb/usbip/stub_dev.c
View File

@@ -267,7 +267,7 @@ static struct stub_device *stub_device_alloc(struct usb_device *udev)
if (!sdev)
return NULL;
sdev->udev = usb_get_dev(udev);
sdev->udev = udev;
/*
* devid is defined with devnum when this driver is first allocated.
@@ -409,7 +409,6 @@ static int stub_probe(struct usb_device *udev)
put_busid_priv(busid_priv);
sdev_free:
usb_put_dev(udev);
stub_device_free(sdev);
return rc;
@@ -488,8 +487,6 @@ static void stub_disconnect(struct usb_device *udev)
/* shutdown the current connection */
shutdown_busid(busid_priv);
usb_put_dev(sdev->udev);
/* we already have busid_priv, just lock busid_lock */
spin_lock(&busid_priv->busid_lock);
/* free sdev */