mirrors/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-05 19:24:01 -04:00
Code Issues Packages Projects Releases Wiki Activity

usb: typec: ps883x: fix missing accessibility check

Browse Source 
Make sure that the retimer is accessible before registering to avoid
having later consumer calls fail to configure it, something which, for
example, can lead to a hotplugged display not being recognised:

	[drm:msm_dp_panel_read_sink_caps [msm]] *ERROR* read dpcd failed -110

Fixes: 257a087c8b ("usb: typec: Add support for Parade PS8830 Type-C Retimer")
Cc: Abel Vesa <abel.vesa@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20250218152933.22992-3-johan+linaro@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Johan Hovold
2025-02-18 16:29:32 +01:00
committed by Greg Kroah-Hartman
parent 9f9de3e02d
commit 9e7968c442
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/usb/typec/mux/ps883x.c
View File

@@ -291,6 +291,7 @@ static int ps883x_retimer_probe(struct i2c_client *client)
struct typec_switch_desc sw_desc = { };
struct typec_retimer_desc rtmr_desc = { };
struct ps883x_retimer *retimer;
unsigned int val;
int ret;
retimer = devm_kzalloc(dev, sizeof(*retimer), GFP_KERNEL);
@@ -360,6 +361,16 @@ static int ps883x_retimer_probe(struct i2c_client *client)
/* firmware initialization delay */
msleep(60);
/* make sure device is accessible */
ret = regmap_read(retimer->regmap, REG_USB_PORT_CONN_STATUS_0,
&val);
if (ret) {
dev_err(dev, "failed to read conn_status_0: %d\n", ret);
if (ret == -ENXIO)
ret = -EIO;
goto err_clk_disable;
}
}
sw_desc.drvdata = retimer;