mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-16 03:11:11 -04:00
Code Issues Packages Projects Releases Wiki Activity

fat: fix stack frame size warnings in KUnit tests

Browse Source 
The kernel test robot reported that on hexagon with clang, several test
functions in fat_test.c exceed the 1280-byte stack frame limit.

The root cause is the compound literal assignment in
fat_test_set_time_offset():

  *sbi = (struct msdos_sb_info){};

struct msdos_sb_info contains two hash tables of 256 hlist_head entries
(FAT_HASH_SIZE), making it several kilobytes. The compound literal
creates a temporary on the stack, and when clang inlines
fat_test_set_time_offset() into each test function, the large temporary
inflates every caller's stack frame beyond the limit.

Replace the compound literal with memset() which zeroes the struct
in-place without a stack temporary.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202603251755.4UYY1Rcd-lkp@intel.com/
Signed-off-by: Christian Brauner <brauner@kernel.org>
This commit is contained in:
Christian Brauner
2026-03-25 17:34:00 +01:00
parent 4bbf3f58e0
commit 94505767bd
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
fs/fat/fat_test.c
View File

@@ -218,7 +218,7 @@ KUNIT_ARRAY_PARAM(fat_truncate_atime, truncate_atime_test_cases,
static void fat_test_set_time_offset(struct msdos_sb_info *sbi, int time_offset)
{
*sbi = (struct msdos_sb_info){};
memset(sbi, 0, sizeof(*sbi));
sbi->options.tz_set = 1;
sbi->options.time_offset = time_offset;
}