mirrors/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-01-20 04:08:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

drm/vmwgfx: fix a memleak in vmw_gmrid_man_get_node

Browse Source 
When ida_alloc_max fails, resources allocated before should be freed,
including *res allocated by kmalloc and ttm_resource_init.

Fixes: d3bcb4b02f ("drm/vmwgfx: switch the TTM backends to self alloc")
Signed-off-by: Zhipeng Lu <alexious@zju.edu.cn>
Signed-off-by: Zack Rusin <zack.rusin@broadcom.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231204091416.3308430-1-alexious@zju.edu.cn
This commit is contained in:
Zhipeng Lu
2023-12-04 17:14:16 +08:00
committed by Zack Rusin
parent 834b1d7205
commit 89709105a6
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c
View File

@@ -64,8 +64,11 @@ static int vmw_gmrid_man_get_node(struct ttm_resource_manager *man,
ttm_resource_init(bo, place, *res);
id = ida_alloc_max(&gman->gmr_ida, gman->max_gmr_ids - 1, GFP_KERNEL);
if (id < 0)
if (id < 0) {
ttm_resource_fini(man, *res);
kfree(*res);
return id;
}
spin_lock(&gman->lock);