mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-07-22 23:17:41 -04:00
Code Issues Packages Projects Releases Wiki Activity

mm/vma: remove mmap_action->success_hook

Browse Source 
This hook was introduced to work around code that seemed to absolutely
require access to a VMA pointer upon mmap().

However, providing this hook leaves a backdoor to drivers getting access
to the very thing mmap_prepare eliminates - a pointer to the VMA.

Let's solve this contradiction by removing it.  The key intended user was
hugetlb, however it seems that the best course now is to avoid allowing
all drivers the ability to work around mmap_prepare, and find a different
solution there.

Link: https://lore.kernel.org/f79434e6d30af6d92999be6b76e197f1847105fa.1780397980.git.ljs@kernel.org
Signed-off-by: Lorenzo Stoakes <ljs@kernel.org>
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jann Horn <jannh@google.com>
Cc: Liam R. Howlett <liam@infradead.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Pedro Falcato <pfalcato@suse.de>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Vlastimil Babka <vbabka@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Lorenzo Stoakes
2026-06-02 12:06:26 +01:00
committed by Andrew Morton
parent 17986198a7
commit 8876dc0780
3 changed files with 0 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
include/linux/mm_types.h
View File

@@ -843,16 +843,6 @@ struct mmap_action {
};
enum mmap_action_type type;
/*
* If specified, this hook is invoked after the selected action has been
* successfully completed. Note that the VMA write lock still held.
*
* The absolute minimum ought to be done here.
*
* Returns 0 on success, or an error code.
*/
int (*success_hook)(const struct vm_area_struct *vma);
/*
* If specified, this hook is invoked when an error occurred when
* attempting the selected action.

2
mm/util.c
View File

@@ -1397,8 +1397,6 @@ static int mmap_action_finish(struct vm_area_struct *vma,
if (!err)
err = call_vma_mapped(vma);
if (!err && action->success_hook)
err = action->success_hook(vma);
/* do_munmap() might take rmap lock, so release if held. */
maybe_rmap_unlock_action(vma, action);

10
tools/testing/vma/include/dup.h
View File

@@ -482,16 +482,6 @@ struct mmap_action {
};
enum mmap_action_type type;
/*
* If specified, this hook is invoked after the selected action has been
* successfully completed. Note that the VMA write lock still held.
*
* The absolute minimum ought to be done here.
*
* Returns 0 on success, or an error code.
*/
int (*success_hook)(const struct vm_area_struct *vma);
/*
* If specified, this hook is invoked when an error occurred when
* attempting the selection action.