mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-08-30 19:13:03 -04:00
Code Issues Packages Projects Releases Wiki Activity

firmware: xilinx: Release all peripheral devices from firmware

Browse Source 
During a kexec restart, only the kernel is reloaded while devices
allocated in firmware persist, causing state mismatches between the
kernel and firmware.

Introduce PM_DEV_ALL_PERIPH node ID (0x18224FFFU) to release all
peripheral devices during kexec. On graceful restarts, this happens in
zynqmp_firmware_shutdown(). On crash kernel restarts, it happens in
zynqmp_firmware_probe() of the reloaded kernel.

Releasing all peripherals depends on firmware support for the
PM_DEV_ALL_PERIPH node ID. On firmware that does not implement it (the
feature check reports a version below PM_API_VERSION_3) the release is
skipped and a warning such as "Bulk device release is not supported by
firmware" is logged, e.g. on Versal NET firmware that predates this API.

Signed-off-by: Jay Buddhabhatti <jay.buddhabhatti@amd.com>
Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Reviewed-by: Prasanna Kumar T S M <ptsm@linux.microsoft.com>
Link: https://patch.msgid.link/20260729122522.3732875-3-jay.buddhabhatti@amd.com
Signed-off-by: Michal Simek <michal.simek@amd.com>
This commit is contained in:
Jay Buddhabhatti
2026-07-29 05:25:21 -07:00
committed by Michal Simek
parent 00bee072c8
commit 84dbfa5519
2 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/firmware/xilinx/zynqmp.c
View File

@@ -2073,7 +2073,7 @@ ATTRIBUTE_GROUPS(zynqmp_firmware);
* zynqmp_clear_pm_state() - Clear subsystem state
* @dev: Device pointer used for logging
*
* Clears PM specific data in EL3 firmware.
* Clears PM specific data in EL3 and platform firmware.
*
* Return: Returns status, either success or error
*/
@@ -2102,6 +2102,19 @@ static int zynqmp_clear_pm_state(struct device *dev)
dev_warn(dev, "TF_A_CLEAR_PM_STATE is not supported by EL3 firmware: %d\n", ret);
ret = 0;
}
/* Check if the firmware supports the PM_DEV_ALL_PERIPH node ID */
ret = do_feature_check_call(PM_RELEASE_NODE);
if (ret >= 0 && ((ret & FIRMWARE_VERSION_MASK) >= PM_API_VERSION_3)) {
/* Attempt to release all peripheral devices via firmware */
ret = zynqmp_pm_release_node(PM_DEV_ALL_PERIPH);
if (ret)
dev_err(dev, "Failed to release all peripheral devices: %d\n", ret);
} else {
dev_warn(dev,
"Bulk device release is not supported by firmware: %d\n", ret);
ret = 0;
}
}
return ret;

4
include/linux/firmware/xlnx-zynqmp.h
View File

@@ -50,6 +50,7 @@
/* PM API versions */
#define PM_API_VERSION_1 1
#define PM_API_VERSION_2 2
#define PM_API_VERSION_3 3
#define PM_PINCTRL_PARAM_SET_VERSION 2
@@ -145,6 +146,9 @@
#define XPM_EVENT_ERROR_MASK_NOC_NCR BIT(13)
#define XPM_EVENT_ERROR_MASK_NOC_CR BIT(12)
/* Node ID for all peripheral devices */
#define PM_DEV_ALL_PERIPH 0x18224FFFU
enum pm_module_id {
PM_MODULE_ID = 0x0,
XPM_MODULE_ID = 0x2,