mirrors/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-05 21:44:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

usb: typec: ps883x: fix probe error handling

Browse Source 
Fix the probe error handling to avoid unbalanced clock disable or
leaving regulators on after probe failure.

Note that the active-low reset pin should also be asserted to avoid
leaking current after disabling the regulators.

Fixes: 257a087c8b ("usb: typec: Add support for Parade PS8830 Type-C Retimer")
Cc: Abel Vesa <abel.vesa@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20250218082243.9318-1-johan+linaro@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Johan Hovold
2025-02-18 09:22:43 +01:00
committed by Greg Kroah-Hartman
parent ba6e518d13
commit 834d1cb7ec
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/usb/typec/mux/ps883x.c
View File

@@ -387,10 +387,11 @@ static int ps883x_retimer_probe(struct i2c_client *client)
err_switch_unregister:
typec_switch_unregister(retimer->sw);
err_vregs_disable:
ps883x_disable_vregs(retimer);
err_clk_disable:
clk_disable_unprepare(retimer->xo_clk);
err_vregs_disable:
gpiod_set_value(retimer->reset_gpio, 1);
ps883x_disable_vregs(retimer);
err_mux_put:
typec_mux_put(retimer->typec_mux);
err_switch_put: