mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-05-08 00:29:36 -04:00
media: pxa_camera: constify vb2_ops structure
Check for vb2_ops structures that are only stored in the ops field of a
vb2_queue structure. That field is declared const, so vb2_ops structures
that have this property can be declared as const also.
This issue was detected using Coccinelle and the following semantic patch:
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct vb2_ops i@p = { ... };
@ok@
identifier r.i;
struct vb2_queue e;
position p;
@@
e.ops = &i@p;
@bad@
position p != {r.p,ok.p};
identifier r.i;
struct vb2_ops e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct vb2_ops i = { ... };
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
committed by
Mauro Carvalho Chehab
parent
9c91e70605
commit
7e645125a8
@@ -1557,7 +1557,7 @@ static void pxac_vb2_stop_streaming(struct vb2_queue *vq)
|
||||
pxa_camera_wakeup(pcdev, buf, VB2_BUF_STATE_ERROR);
|
||||
}
|
||||
|
||||
static struct vb2_ops pxac_vb2_ops = {
|
||||
static const struct vb2_ops pxac_vb2_ops = {
|
||||
.queue_setup = pxac_vb2_queue_setup,
|
||||
.buf_init = pxac_vb2_init,
|
||||
.buf_prepare = pxac_vb2_prepare,
|
||||
|
||||
Reference in New Issue
Block a user