mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-21 19:35:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

ASoC: codecs: wcd939x-sdw: use devres for regmap allocation

Browse Source 
Components are bound inside a new devres group so that any resources
allocated can be released on bind failure and on unbind without
affecting anything else.

Switch to using device managed regmap allocation for consistency while
dropping the misleading comment claiming that devres cannot be used.

Cc: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20251201092259.11761-1-johan@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Johan Hovold
2025-12-01 10:22:59 +01:00
committed by Mark Brown
parent 3622dc47a4
commit 7a8447fc71
1 changed files with 2 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
sound/soc/codecs/wcd939x-sdw.c
View File

@@ -1384,12 +1384,7 @@ static int wcd9390_probe(struct sdw_slave *pdev, const struct sdw_device_id *id)
}
if (wcd->is_tx) {
/*
* Do not use devres here since devres_release_group() could
* be called by component_unbind() id the aggregate device
* fails to bind.
*/
wcd->regmap = regmap_init_sdw(pdev, &wcd939x_regmap_config);
wcd->regmap = devm_regmap_init_sdw(pdev, &wcd939x_regmap_config);
if (IS_ERR(wcd->regmap))
return dev_err_probe(dev, PTR_ERR(wcd->regmap),
"Regmap init failed\n");
@@ -1400,30 +1395,20 @@ static int wcd9390_probe(struct sdw_slave *pdev, const struct sdw_device_id *id)
ret = component_add(dev, &wcd_sdw_component_ops);
if (ret)
goto err_free_regmap;
return ret;
/* Set suspended until aggregate device is bind */
pm_runtime_set_suspended(dev);
return 0;
err_free_regmap:
if (wcd->regmap)
regmap_exit(wcd->regmap);
return ret;
}
static int wcd9390_remove(struct sdw_slave *pdev)
{
struct device *dev = &pdev->dev;
struct wcd939x_sdw_priv *wcd = dev_get_drvdata(dev);
component_del(dev, &wcd_sdw_component_ops);
if (wcd->regmap)
regmap_exit(wcd->regmap);
return 0;
}