mirrors/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-06 13:27:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

net: Add ->exit_rtnl() hook to struct pernet_operations.

Browse Source 
struct pernet_operations provides two batching hooks; ->exit_batch()
and ->exit_batch_rtnl().

The batching variant is beneficial if ->exit() meets any of the
following conditions:

  1) ->exit() repeatedly acquires a global lock for each netns

  2) ->exit() has a time-consuming operation that can be factored
     out (e.g. synchronize_rcu(), smp_mb(), etc)

  3) ->exit() does not need to repeat the same iterations for each
     netns (e.g. inet_twsk_purge())

Currently, none of the ->exit_batch_rtnl() functions satisfy any of
the above conditions because RTNL is factored out and held by the
caller and all of these functions iterate over the dying netns list.

Also, we want to hold per-netns RTNL there but avoid spreading
__rtnl_net_lock() across multiple locations.

Let's add ->exit_rtnl() hook and run it under __rtnl_net_lock().

The following patches will convert all ->exit_batch_rtnl() users
to ->exit_rtnl().

Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
Link: https://patch.msgid.link/20250411205258.63164-4-kuniyu@amazon.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Kuniyuki Iwashima
2025-04-11 13:52:32 -07:00
committed by Jakub Kicinski
parent fed176bf31
commit 7a60d91c69
2 changed files with 41 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/net/net_namespace.h
View File

@@ -475,6 +475,8 @@ struct pernet_operations {
void (*exit)(struct net *net);
void (*exit_batch)(struct list_head *net_exit_list);
/* Following method is called with RTNL held. */
void (*exit_rtnl)(struct net *net,
struct list_head *dev_kill_list);
void (*exit_batch_rtnl)(struct list_head *net_exit_list,
struct list_head *dev_kill_list);
unsigned int * const id;

53
net/core/net_namespace.c
View File

@@ -163,16 +163,51 @@ static void ops_pre_exit_list(const struct pernet_operations *ops,
}
}
static void ops_exit_rtnl_list(const struct list_head *ops_list,
const struct pernet_operations *ops,
struct list_head *net_exit_list)
{
const struct pernet_operations *saved_ops = ops;
LIST_HEAD(dev_kill_list);
struct net *net;
rtnl_lock();
list_for_each_entry(net, net_exit_list, exit_list) {
__rtnl_net_lock(net);
ops = saved_ops;
list_for_each_entry_continue_reverse(ops, ops_list, list) {
if (ops->exit_rtnl)
ops->exit_rtnl(net, &dev_kill_list);
}
__rtnl_net_unlock(net);
}
ops = saved_ops;
list_for_each_entry_continue_reverse(ops, ops_list, list) {
if (ops->exit_batch_rtnl)
ops->exit_batch_rtnl(net_exit_list, &dev_kill_list);
}
unregister_netdevice_many(&dev_kill_list);
rtnl_unlock();
}
static void ops_exit_list(const struct pernet_operations *ops,
struct list_head *net_exit_list)
{
struct net *net;
if (ops->exit) {
struct net *net;
list_for_each_entry(net, net_exit_list, exit_list) {
ops->exit(net);
cond_resched();
}
}
if (ops->exit_batch)
ops->exit_batch(net_exit_list);
}
@@ -213,18 +248,8 @@ static void ops_undo_list(const struct list_head *ops_list,
else
synchronize_rcu();
if (hold_rtnl) {
LIST_HEAD(dev_kill_list);
ops = saved_ops;
rtnl_lock();
list_for_each_entry_continue_reverse(ops, ops_list, list) {
if (ops->exit_batch_rtnl)
ops->exit_batch_rtnl(net_exit_list, &dev_kill_list);
}
unregister_netdevice_many(&dev_kill_list);
rtnl_unlock();
}
if (hold_rtnl)
ops_exit_rtnl_list(ops_list, saved_ops, net_exit_list);
ops = saved_ops;
list_for_each_entry_continue_reverse(ops, ops_list, list)
@@ -238,7 +263,7 @@ static void ops_undo_list(const struct list_head *ops_list,
static void ops_undo_single(struct pernet_operations *ops,
struct list_head *net_exit_list)
{
bool hold_rtnl = !!ops->exit_batch_rtnl;
bool hold_rtnl = ops->exit_rtnl || ops->exit_batch_rtnl;
LIST_HEAD(ops_list);
list_add(&ops->list, &ops_list);