mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-08-30 10:00:03 -04:00
Code Issues Packages Projects Releases Wiki Activity

spi: spacemit: drop redundant dev_err_probe() around irq helpers

Browse Source 
platform_get_irq() and devm_request_irq() already print an error
message via dev_err_probe() on failure, so wrapping them with
another dev_err_probe() results in duplicate error output.

Return the error code directly instead.

Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
Link: https://patch.msgid.link/119b5f8e3ac68221307cbfcd227dc8546be0eaeb.1784527556.git.xiaopei01@kylinos.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Pei Xiao
2026-07-20 14:08:44 +08:00
committed by Mark Brown
parent 8955fbad8a
commit 79052a6a6f
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/spi/spi-spacemit-k1.c
View File

@@ -737,12 +737,12 @@ static int k1_spi_probe(struct platform_device *pdev)
drv_data->irq = platform_get_irq(pdev, 0);
if (drv_data->irq < 0)
return dev_err_probe(dev, drv_data->irq, "error getting IRQ\n");
return drv_data->irq;
ret = devm_request_irq(dev, drv_data->irq, k1_spi_ssp_isr,
IRQF_SHARED, dev_name(dev), drv_data);
if (ret < 0)
return dev_err_probe(dev, ret, "error requesting IRQ\n");
return ret;
/* Initialize the host structure, then register it */
host->dev.of_node = dev_of_node(dev);