mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-13 14:09:38 -04:00
Code Issues Packages Projects Releases Wiki Activity

greybus: legacy: fix a null pointer dereference

Browse Source 
When gb_protocol_get() fails in legacy_connection_create(), we end up
bailing-out before assigning lc->connection and lc->protocol. Calling
legacy_connection_destroy() in that case results in a null pointer
dereference.

Check if lc->connection is not null before freeing it.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Reviewed-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Bartosz Golaszewski
2016-01-27 13:17:52 +01:00
committed by Greg Kroah-Hartman
parent 5bee760890
commit 6e304f5963
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/staging/greybus/legacy.c
View File

@@ -148,6 +148,9 @@ static int legacy_connection_create(struct legacy_connection *lc,
static void legacy_connection_destroy(struct legacy_connection *lc)
{
if (!lc->connection)
return;
lc->connection->protocol = NULL;
gb_connection_destroy(lc->connection);