mirrors/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-05 11:01:06 -04:00
Code Issues Packages Projects Releases Wiki Activity

drm/i915: Treat DMRRS as static DRRS

Browse Source 
Some machines declare DRRS type = seamless, DRRS = no, DMRRS = yes.
I *think* DMRRS stands for "dynamcic media refresh rate", and
I suspect the way it's meant to work is that it lets the driver
switch refresh rates to match the frame rate for media playback.
Obviously for us all that kind of policy stuff is entirely up to
userspace, so the only thing we may do is make the extra refresh
rate(s) available.

So let's treat this case as just static DRRS for now. In the
future We might want to differentiate the "seamless w/ downclocking"
vs. "seamless w/o downclocking" cases so that we could do seamless
refresh rate changes for systems that only claim to support DMRRS.

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/125
Acked-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220531191844.11313-7-ville.syrjala@linux.intel.com
This commit is contained in:
Ville Syrjälä
2022-05-31 22:18:44 +03:00
parent 700034566d
commit 5a18db2e92
1 changed files with 20 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
drivers/gpu/drm/i915/display/intel_bios.c
View File

@@ -1278,8 +1278,16 @@ parse_panel_driver_features(struct drm_i915_private *i915,
* static DRRS is 0 and DRRS not supported is represented by
* driver->drrs_enabled=false
*/
if (!driver->drrs_enabled)
panel->vbt.drrs_type = DRRS_TYPE_NONE;
if (!driver->drrs_enabled && panel->vbt.drrs_type != DRRS_TYPE_NONE) {
/*
* FIXME Should DMRRS perhaps be treated as seamless
* but without the automatic downclocking?
*/
if (driver->dmrrs_enabled)
panel->vbt.drrs_type = DRRS_TYPE_STATIC;
else
panel->vbt.drrs_type = DRRS_TYPE_NONE;
}
panel->vbt.psr.enable = driver->psr_enabled;
}
@@ -1309,8 +1317,16 @@ parse_power_conservation_features(struct drm_i915_private *i915,
* static DRRS is 0 and DRRS not supported is represented by
* power->drrs & BIT(panel_type)=false
*/
if (!(power->drrs & BIT(panel_type)))
panel->vbt.drrs_type = DRRS_TYPE_NONE;
if (!(power->drrs & BIT(panel_type)) && panel->vbt.drrs_type != DRRS_TYPE_NONE) {
/*
* FIXME Should DMRRS perhaps be treated as seamless
* but without the automatic downclocking?
*/
if (power->dmrrs & BIT(panel_type))
panel->vbt.drrs_type = DRRS_TYPE_STATIC;
else
panel->vbt.drrs_type = DRRS_TYPE_NONE;
}
if (i915->vbt.version >= 232)
panel->vbt.edp.hobl = power->hobl & BIT(panel_type);