mirrors/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-02-25 19:50:33 -05:00
Code Issues Packages Projects Releases Wiki Activity

wifi: iwlwifi: Fix uninitialized variable with __free()

Browse Source 
Pointers declared with the __free(kfree) attribute need to be initialized
because they will be passed to kfree() on every return path.  There are
two return statement before the "cmd" pointer is initialized so this
leads to an uninitialized variable bug.

Fixes: d1e879ec60 ("wifi: iwlwifi: add iwlmld sub-driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/f7c17a7f-f173-43bf-bc39-316b8adde349@stanley.mountain
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
This commit is contained in:
Dan Carpenter
2025-03-12 11:31:40 +03:00
committed by Johannes Berg
parent 34670beb48
commit 54be64fdf3
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/wireless/intel/iwlwifi/mld/debugfs.c
View File

@@ -556,8 +556,8 @@ iwl_dbgfs_vif_twt_setup_write(struct iwl_mld *mld, char *buf, size_t count,
};
struct ieee80211_vif *vif = data;
struct iwl_mld_vif *mld_vif = iwl_mld_vif_from_mac80211(vif);
struct iwl_dhc_cmd *cmd __free(kfree) = NULL;
struct iwl_dhc_twt_operation *dhc_twt_cmd;
struct iwl_dhc_cmd *cmd __free(kfree);
u64 target_wake_time;
u32 twt_operation, interval_exp, interval_mantissa, min_wake_duration;
u8 trigger, flow_type, flow_id, protection, tenth_param;