mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-07 19:49:33 -04:00
Code Issues Packages Projects Releases Wiki Activity

wifi: rtw89: uninitialized variable on error in rtw89_early_fw_feature_recognize()

Browse Source 
If request_partial_firmware_into_buf() fails then "firmware" is not
initialized and the release_firmware(firmware) will crash.

Fixes: deebea35d6 ("wifi: rtw89: early recognize FW feature to decide if chanctx")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/YyMzDtX/3fUBnonC@kili
This commit is contained in:
Dan Carpenter
2022-09-15 17:13:34 +03:00
committed by Kalle Valo
parent f2c6e7ca3e
commit 4c3140f4ce
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/wireless/realtek/rtw89/fw.c
View File

@@ -271,7 +271,7 @@ void rtw89_early_fw_feature_recognize(struct device *device,
device, &buf, sizeof(buf), 0);
if (ret) {
dev_err(device, "failed to early request firmware: %d\n", ret);
goto out;
return;
}
ver_code = buf.mfw_hdr.sig != RTW89_MFW_SIG ?