mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-12-27 10:01:39 -05:00
perf top: Use evlist__new_default when no events specified
Rather than distributing the code doing similar things to evlist__new_default, use the one implementation so that paranoia and wildcard scanning can be optimized. Signed-off-by: Ian Rogers <irogers@google.com> Tested-by: James Clark <james.clark@linaro.org> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
This commit is contained in:
@@ -1695,11 +1695,13 @@ int cmd_top(int argc, const char **argv)
|
||||
goto out_delete_evlist;
|
||||
|
||||
if (!top.evlist->core.nr_entries) {
|
||||
bool can_profile_kernel = perf_event_paranoid_check(1);
|
||||
int err = parse_event(top.evlist, can_profile_kernel ? "cycles:P" : "cycles:Pu");
|
||||
struct evlist *def_evlist = evlist__new_default();
|
||||
|
||||
if (err)
|
||||
if (!def_evlist)
|
||||
goto out_delete_evlist;
|
||||
|
||||
evlist__splice_list_tail(top.evlist, &def_evlist->core.entries);
|
||||
evlist__delete(def_evlist);
|
||||
}
|
||||
|
||||
status = evswitch__init(&top.evswitch, top.evlist, stderr);
|
||||
|
||||
Reference in New Issue
Block a user