mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-07-22 03:27:30 -04:00
Code Issues Packages Projects Releases Wiki Activity

crypto: talitos - use devm_platform_ioremap_resource()

Browse Source 
platform_get_resource and devm_ioremap effectively open codes this.

The return type of devm_platform_ioremap_resource() is also nice as it
has multiple errors that it can return.

Because it internally calls devm_request_mem_region(), reg values and
sizes cannot overlap. This was manually verified to be the case for all
talitos users.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Rosen Penev
2026-05-07 16:44:16 -07:00
committed by Herbert Xu
parent 6e12daff6e
commit 463be1c718
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/crypto/talitos.c
View File

@@ -3413,7 +3413,6 @@ static int talitos_probe(struct platform_device *ofdev)
unsigned int num_channels;
int i, err;
int stride;
struct resource *res;
if (of_property_read_u32(np, "fsl,num-channels", &num_channels))
return -EINVAL;
@@ -3432,13 +3431,10 @@ static int talitos_probe(struct platform_device *ofdev)
spin_lock_init(&priv->reg_lock);
res = platform_get_resource(ofdev, IORESOURCE_MEM, 0);
if (!res)
return -ENXIO;
priv->reg = devm_ioremap(dev, res->start, resource_size(res));
if (!priv->reg) {
priv->reg = devm_platform_ioremap_resource(ofdev, 0);
if (IS_ERR(priv->reg)) {
dev_err(dev, "failed to of_iomap\n");
err = -ENOMEM;
err = PTR_ERR(priv->reg);
goto err_out;
}