mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-08 00:29:36 -04:00
Code Issues Packages Projects Releases Wiki Activity

selftests/bpf: validate struct_ops early failure detection logic

Browse Source 
Add a simple test that validates that libbpf will reject isolated
struct_ops program early with helpful warning message.

Also validate that explicit use of such BPF program through BPF skeleton
after BPF object is open won't trigger any warnings.

Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/r/20240507001335.1445325-7-andrii@kernel.org
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
This commit is contained in:
Andrii Nakryiko
2024-05-06 17:13:34 -07:00
committed by Martin KaFai Lau
parent c78420bafe
commit 41df0733ea
2 changed files with 64 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
tools/testing/selftests/bpf/prog_tests/test_struct_ops_module.c
View File

@@ -5,6 +5,7 @@
#include "struct_ops_module.skel.h"
#include "struct_ops_nulled_out_cb.skel.h"
#include "struct_ops_forgotten_cb.skel.h"
static void check_map_info(struct bpf_map_info *info)
{
@@ -199,6 +200,48 @@ static void test_struct_ops_nulled_out_cb(void)
struct_ops_nulled_out_cb__destroy(skel);
}
/* validate that libbpf generates reasonable error message if struct_ops is
* not referenced in any struct_ops map
*/
static void test_struct_ops_forgotten_cb(void)
{
struct struct_ops_forgotten_cb *skel;
char *log;
int err;
skel = struct_ops_forgotten_cb__open();
if (!ASSERT_OK_PTR(skel, "skel_open"))
return;
start_libbpf_log_capture();
err = struct_ops_forgotten_cb__load(skel);
if (!ASSERT_ERR(err, "skel_load"))
goto cleanup;
log = stop_libbpf_log_capture();
ASSERT_HAS_SUBSTR(log,
"prog 'test_1_forgotten': SEC(\"struct_ops\") program isn't referenced anywhere, did you forget to use it?",
"libbpf_log");
free(log);
struct_ops_forgotten_cb__destroy(skel);
/* now let's programmatically use it, we should be fine now */
skel = struct_ops_forgotten_cb__open();
if (!ASSERT_OK_PTR(skel, "skel_open"))
return;
skel->struct_ops.ops->test_1 = skel->progs.test_1_forgotten; /* not anymore */
err = struct_ops_forgotten_cb__load(skel);
if (!ASSERT_OK(err, "skel_load"))
goto cleanup;
cleanup:
struct_ops_forgotten_cb__destroy(skel);
}
void serial_test_struct_ops_module(void)
{
if (test__start_subtest("test_struct_ops_load"))
@@ -209,5 +252,7 @@ void serial_test_struct_ops_module(void)
test_struct_ops_incompatible();
if (test__start_subtest("test_struct_ops_null_out_cb"))
test_struct_ops_nulled_out_cb();
if (test__start_subtest("struct_ops_forgotten_cb"))
test_struct_ops_forgotten_cb();
}

19
tools/testing/selftests/bpf/progs/struct_ops_forgotten_cb.c Normal file
View File

@@ -0,0 +1,19 @@
// SPDX-License-Identifier: GPL-2.0
/* Copyright (c) 2024 Meta Platforms, Inc. and affiliates. */
#include <vmlinux.h>
#include <bpf/bpf_tracing.h>
#include "../bpf_testmod/bpf_testmod.h"
char _license[] SEC("license") = "GPL";
SEC("struct_ops/test_1")
int BPF_PROG(test_1_forgotten)
{
return 0;
}
SEC(".struct_ops.link")
struct bpf_testmod_ops ops = {
/* we forgot to reference test_1_forgotten above, oops */
};