mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-16 14:51:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

comedi: dmm32at: Add sanity check for I/O base address

Browse Source 
The "dmm32at" driver uses an admin-supplied configuration option
(`it->options[0]`) to configure the I/O port base address of a
Diamond-MM-32-AT board.  It currently allows any base address to be
configured but the hardware only supports 8 possible base addresses
(selected by 3 on-board jumpers).  These are 0x100, 0x140, 0x180, 0x200,
0x280, 0x300, 0x340, and 0x380.

Add a sanity check to ensure the device is not configured at an
unsupported base address.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Link: https://patch.msgid.link/20260130170416.49994-19-abbotti@mev.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Ian Abbott
2026-01-30 16:47:43 +00:00
committed by Greg Kroah-Hartman
parent 46fe103de0
commit 40f86ce1d1
1 changed files with 19 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
drivers/comedi/drivers/dmm32at.c
View File

@@ -572,11 +572,27 @@ static int dmm32at_attach(struct comedi_device *dev,
struct comedi_devconfig *it)
{
struct comedi_subdevice *s;
unsigned int iobase = it->options[0];
int ret;
ret = comedi_request_region(dev, it->options[0], 0x10);
if (ret)
return ret;
switch (iobase) {
case 0x100:
case 0x140:
case 0x180:
case 0x200:
case 0x280:
case 0x300:
case 0x340:
case 0x380:
ret = comedi_request_region(dev, iobase, 0x10);
if (ret)
return ret;
break;
default:
dev_err(dev->class_dev, "unsupported base address %#x\n",
iobase);
return -EINVAL;
}
ret = dmm32at_reset(dev);
if (ret) {