mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-10 21:14:56 -04:00
Code Issues Packages Projects Releases Wiki Activity

SDCA Bug Fixes

Browse Source 
Merge series from Charles Keepax <ckeepax@opensource.cirrus.com>:

Some small SDCA bug fixes reported from various sources. An array bounds
check, an uninitialised variable and some memory allocations that should
zero initialise.

Charles Keepax (3):
  ASoC: SDCA: Fix off by one error in IRQ bound check
  ASoC: SDCA: Avoid use of uninitialised local name variable
  ASoC: SDCA: Update memory allocations to zero initialise

 sound/soc/sdca/sdca_asoc.c       | 12 ++++++------
 sound/soc/sdca/sdca_interrupts.c |  5 ++---
 2 files changed, 8 insertions(+), 9 deletions(-)

--
2.39.5
This commit is contained in:
Mark Brown
2025-07-15 22:40:13 +01:00
parent dd10ed1caf 15247b5a63
commit 3f998cd512
2 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
sound/soc/sdca/sdca_asoc.c
View File

@@ -230,11 +230,11 @@ static int entity_early_parse_ge(struct device *dev,
if (!control_name)
return -ENOMEM;
kctl = devm_kmalloc(dev, sizeof(*kctl), GFP_KERNEL);
kctl = devm_kzalloc(dev, sizeof(*kctl), GFP_KERNEL);
if (!kctl)
return -ENOMEM;
soc_enum = devm_kmalloc(dev, sizeof(*soc_enum), GFP_KERNEL);
soc_enum = devm_kzalloc(dev, sizeof(*soc_enum), GFP_KERNEL);
if (!soc_enum)
return -ENOMEM;
@@ -561,11 +561,11 @@ static int entity_parse_su_class(struct device *dev,
const char **texts;
int i;
kctl = devm_kmalloc(dev, sizeof(*kctl), GFP_KERNEL);
kctl = devm_kzalloc(dev, sizeof(*kctl), GFP_KERNEL);
if (!kctl)
return -ENOMEM;
soc_enum = devm_kmalloc(dev, sizeof(*soc_enum), GFP_KERNEL);
soc_enum = devm_kzalloc(dev, sizeof(*soc_enum), GFP_KERNEL);
if (!soc_enum)
return -ENOMEM;
@@ -672,7 +672,7 @@ static int entity_parse_mu(struct device *dev,
if (!control_name)
return -ENOMEM;
mc = devm_kmalloc(dev, sizeof(*mc), GFP_KERNEL);
mc = devm_kzalloc(dev, sizeof(*mc), GFP_KERNEL);
if (!mc)
return -ENOMEM;
@@ -926,7 +926,7 @@ static int populate_control(struct device *dev,
if (!control_name)
return -ENOMEM;
mc = devm_kmalloc(dev, sizeof(*mc), GFP_KERNEL);
mc = devm_kzalloc(dev, sizeof(*mc), GFP_KERNEL);
if (!mc)
return -ENOMEM;

5
sound/soc/sdca/sdca_interrupts.c
View File

@@ -262,7 +262,7 @@ int sdca_irq_request(struct device *dev, struct sdca_interrupt_info *info,
{
int ret;
if (sdca_irq < 0 || sdca_irq > SDCA_MAX_INTERRUPTS) {
if (sdca_irq < 0 || sdca_irq >= SDCA_MAX_INTERRUPTS) {
dev_err(dev, "bad irq request: %d\n", sdca_irq);
return -EINVAL;
}
@@ -342,7 +342,6 @@ int sdca_irq_populate(struct sdca_function_data *function,
int irq = control->interrupt_position;
struct sdca_interrupt *interrupt;
irq_handler_t handler;
const char *name;
int ret;
if (irq == SDCA_NO_INTERRUPT) {
@@ -385,7 +384,7 @@ int sdca_irq_populate(struct sdca_function_data *function,
handler, interrupt);
if (ret) {
dev_err(dev, "failed to request irq %s: %d\n",
name, ret);
interrupt->name, ret);
return ret;
}
}