mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-16 02:01:18 -04:00
Code Issues Packages Projects Releases Wiki Activity

scsi: target: core: Fix complete_type use

Browse Source 
There were two copy and paste type of errors where I swapped 'complete'
with 'submit' names. Use the correct variables and definitions.

This problem was found by Dmitry Bogdanov and this patch builds on top of
his patch to fix a second instance that was found.

Fixes: 06933066d8 ("scsi: target: Add support for completing commands from backend context")
Signed-off-by: Dmitry Bogdanov <d.bogdanov@yadro.com>
[mnc: Fixed second instance]
Signed-off-by: Mike Christie <michael.christie@oracle.com>
Link: https://patch.msgid.link/20260307220630.131008-1-michael.christie@oracle.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Mike Christie
2026-03-07 16:06:30 -06:00
committed by Martin K. Petersen
parent 0e124af675
commit 3e70441fb5
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/target/target_core_device.c
View File

@@ -813,7 +813,7 @@ struct se_device *target_alloc_device(struct se_hba *hba, const char *name)
DA_UNMAP_ZEROES_DATA_DEFAULT;
dev->dev_attrib.max_write_same_len = DA_MAX_WRITE_SAME_LEN;
dev->dev_attrib.submit_type = TARGET_FABRIC_DEFAULT_SUBMIT;
dev->dev_attrib.submit_type = TARGET_FABRIC_DEFAULT_COMPL;
dev->dev_attrib.complete_type = TARGET_FABRIC_DEFAULT_COMPL;
/* Skip allocating lun_stats since we can't export them. */
xcopy_lun = &dev->xcopy_lun;

2
drivers/target/target_core_transport.c
View File

@@ -917,7 +917,7 @@ static void target_complete(struct se_cmd *cmd, int success)
da = &cmd->se_dev->dev_attrib;
if (da->complete_type == TARGET_FABRIC_DEFAULT_COMPL)
compl_type = wwn->wwn_tf->tf_ops->default_compl_type;
else if (da->complete_type == TARGET_DIRECT_SUBMIT &&
else if (da->complete_type == TARGET_DIRECT_COMPL &&
wwn->wwn_tf->tf_ops->direct_compl_supp)
compl_type = TARGET_DIRECT_COMPL;
else