mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-16 03:11:11 -04:00
Code Issues Packages Projects Releases Wiki Activity

pinctrl: core: use dev_err_probe() when applying state

Browse Source 
When applying a pinctrl state, -EPROBE_DEFER may be returned if
dependencies are not ready and the consumer will retry probing.

This is normal probe ordering behaviour and not a real error.
However, pinctrl core currently logs:

  "Error applying setting, reverse things back"

even when the return value is -EPROBE_DEFER, resulting in noisy
boot-time error messages.

Replace dev_err() with dev_err_probe() to handle -EPROBE_DEFER
consistently and suppress error logging for deferred probes.

No functional change intended.

Signed-off-by: Michal Piekos <michal.piekos@mmpsystems.pl>
Signed-off-by: Linus Walleij <linusw@kernel.org>
This commit is contained in:
Michal Piekos
2026-03-01 17:46:31 +01:00
committed by Linus Walleij
parent cc2f5e2aeb
commit 33d4feff67
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/pinctrl/core.c
View File

@@ -1350,7 +1350,8 @@ static int pinctrl_commit_state(struct pinctrl *p, struct pinctrl_state *state)
goto restore_old_state;
unapply_new_state:
dev_err(p->dev, "Error applying setting, reverse things back\n");
dev_err_probe(p->dev, ret,
"Error applying setting, reverse things back\n");
/*
* All we can do here is pinmux_disable_setting.