mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-14 10:02:33 -04:00
Code Issues Packages Projects Releases Wiki Activity

greybus: fix gb_add_module() by enabling the device_add()

Browse Source 
Without the gb_module device being added, we have no parent
device for any of the greybus subdevs to be added. Do the
device_add() before creating subdevs as we need it then
to register any children in the various greybus protocol
drivers.

Signed-off-by: Matt Porter <mporter@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
This commit is contained in:
Matt Porter
2014-10-03 13:38:24 -04:00
committed by Greg Kroah-Hartman
parent 2f30d9ffee
commit 32dff13d21
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/staging/greybus/core.c
View File

@@ -231,14 +231,20 @@ void gb_add_module(struct greybus_host_device *hd, u8 module_id,
device_initialize(&gmod->dev);
dev_set_name(&gmod->dev, "%d", module_id);
retval = gb_init_subdevs(gmod, &fake_greybus_module_id);
retval = device_add(&gmod->dev);
if (retval)
goto error;
// FIXME device_add(&gmod->dev);
retval = gb_init_subdevs(gmod, &fake_greybus_module_id);
if (retval)
goto error_subdevs;
//return gmod;
return;
error_subdevs:
device_del(&gmod->dev);
error:
put_device(&gmod->dev);
greybus_module_release(&gmod->dev);