mirrors/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-02-22 01:50:16 -05:00
Code Issues Packages Projects Releases Wiki Activity

iio: adc: xilinx-ams: use device_* to iterate over device child nodes

Browse Source 
Use `device_for_each_child_node_scoped()` in `ams_parse_firmware()`
to explicitly state device child node access, and simplify the child
node handling as it is not required outside the loop.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Reviewed-by: Mike Leach <mike.leach@linaro.org>
Link: https://patch.msgid.link/20240820-device_child_node_access-v3-1-1ee09bdedb9e@gmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
Javier Carrasco
2024-08-20 21:02:26 +02:00
committed by Jonathan Cameron
parent 192be24574
commit 31c022a4f4
1 changed files with 5 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/iio/adc/xilinx-ams.c
View File

@@ -1275,7 +1275,6 @@ static int ams_parse_firmware(struct iio_dev *indio_dev)
struct ams *ams = iio_priv(indio_dev);
struct iio_chan_spec *ams_channels, *dev_channels;
struct device *dev = indio_dev->dev.parent;
struct fwnode_handle *child = NULL;
struct fwnode_handle *fwnode = dev_fwnode(dev);
size_t ams_size;
int ret, ch_cnt = 0, i, rising_off, falling_off;
@@ -1297,16 +1296,12 @@ static int ams_parse_firmware(struct iio_dev *indio_dev)
num_channels += ret;
}
fwnode_for_each_child_node(fwnode, child) {
if (fwnode_device_is_available(child)) {
ret = ams_init_module(indio_dev, child, ams_channels + num_channels);
if (ret < 0) {
fwnode_handle_put(child);
return ret;
}
device_for_each_child_node_scoped(dev, child) {
ret = ams_init_module(indio_dev, child, ams_channels + num_channels);
if (ret < 0)
return ret;
num_channels += ret;
}
num_channels += ret;
}
for (i = 0; i < num_channels; i++) {