mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-07-22 02:17:36 -04:00
udp_tunnel: Pass struct sock to setup_udp_tunnel_sock().
None of the udp_tunnel users need struct socket in their fast paths; it is only used for tunnel setup / teardown. Even setup_udp_tunnel_sock() does not need struct socket. Let's change setup_udp_tunnel_sock() to take struct sock instead of struct socket. Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com> Link: https://patch.msgid.link/20260502031401.3557229-3-kuniyu@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
committed by
Jakub Kicinski
parent
944bfc1b1c
commit
2cba193628
@@ -283,7 +283,7 @@ static struct socket *rxe_setup_udp_tunnel(struct net *net, __be16 port,
|
||||
tnl_cfg.encap_rcv = rxe_udp_encap_recv;
|
||||
|
||||
/* Setup UDP tunnel */
|
||||
setup_udp_tunnel_sock(net, sock, &tnl_cfg);
|
||||
setup_udp_tunnel_sock(net, sock->sk, &tnl_cfg);
|
||||
|
||||
return sock;
|
||||
}
|
||||
|
||||
@@ -2979,7 +2979,7 @@ static int amt_socket_create(struct amt_dev *amt)
|
||||
tunnel_cfg.encap_rcv = amt_rcv;
|
||||
tunnel_cfg.encap_err_lookup = amt_err_lookup;
|
||||
tunnel_cfg.encap_destroy = NULL;
|
||||
setup_udp_tunnel_sock(amt->net, sock, &tunnel_cfg);
|
||||
setup_udp_tunnel_sock(amt->net, sock->sk, &tunnel_cfg);
|
||||
|
||||
rcu_assign_pointer(amt->sock, sock);
|
||||
return 0;
|
||||
|
||||
@@ -268,7 +268,7 @@ static int bareudp_socket_create(struct bareudp_dev *bareudp, __be16 port)
|
||||
tunnel_cfg.encap_rcv = bareudp_udp_encap_recv;
|
||||
tunnel_cfg.encap_err_lookup = bareudp_err_lookup;
|
||||
tunnel_cfg.encap_destroy = NULL;
|
||||
setup_udp_tunnel_sock(bareudp->net, sock, &tunnel_cfg);
|
||||
setup_udp_tunnel_sock(bareudp->net, sock->sk, &tunnel_cfg);
|
||||
|
||||
rcu_assign_pointer(bareudp->sock, sock);
|
||||
return 0;
|
||||
|
||||
@@ -1006,7 +1006,7 @@ static struct geneve_sock *geneve_socket_create(struct net *net, __be16 port,
|
||||
tunnel_cfg.encap_rcv = geneve_udp_encap_recv;
|
||||
tunnel_cfg.encap_err_lookup = geneve_udp_encap_err_lookup;
|
||||
tunnel_cfg.encap_destroy = NULL;
|
||||
setup_udp_tunnel_sock(net, sock, &tunnel_cfg);
|
||||
setup_udp_tunnel_sock(net, sock->sk, &tunnel_cfg);
|
||||
list_add(&gs->list, &gn->sock_list);
|
||||
return gs;
|
||||
}
|
||||
|
||||
@@ -1434,7 +1434,7 @@ static struct sock *gtp_create_sock(int type, struct gtp_dev *gtp,
|
||||
tuncfg.encap_rcv = gtp_encap_recv;
|
||||
tuncfg.encap_destroy = NULL;
|
||||
|
||||
setup_udp_tunnel_sock(net, sock, &tuncfg);
|
||||
setup_udp_tunnel_sock(net, sock->sk, &tuncfg);
|
||||
|
||||
return sock->sk;
|
||||
}
|
||||
@@ -1689,7 +1689,7 @@ static struct sock *gtp_encap_enable_socket(int fd, int type,
|
||||
tuncfg.encap_rcv = gtp_encap_recv;
|
||||
tuncfg.encap_destroy = gtp_encap_destroy;
|
||||
|
||||
setup_udp_tunnel_sock(sock_net(sock->sk), sock, &tuncfg);
|
||||
setup_udp_tunnel_sock(sock_net(sock->sk), sk, &tuncfg);
|
||||
|
||||
out_rel_sock:
|
||||
release_sock(sock->sk);
|
||||
|
||||
@@ -399,7 +399,7 @@ int ovpn_udp_socket_attach(struct ovpn_socket *ovpn_sock, struct socket *sock,
|
||||
if (!old_data) {
|
||||
/* socket is currently unused - we can take it */
|
||||
rcu_read_unlock();
|
||||
setup_udp_tunnel_sock(sock_net(ovpn_sock->sk), sock, &cfg);
|
||||
setup_udp_tunnel_sock(sock_net(ovpn_sock->sk), sock->sk, &cfg);
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
||||
@@ -172,7 +172,7 @@ static struct socket *pfcp_create_sock(struct pfcp_dev *pfcp)
|
||||
tuncfg.encap_rcv = pfcp_encap_recv;
|
||||
tuncfg.encap_type = 1;
|
||||
|
||||
setup_udp_tunnel_sock(net, sock, &tuncfg);
|
||||
setup_udp_tunnel_sock(net, sock->sk, &tuncfg);
|
||||
|
||||
return sock;
|
||||
}
|
||||
|
||||
@@ -3620,7 +3620,7 @@ static struct vxlan_sock *vxlan_socket_create(struct net *net, bool ipv6,
|
||||
tunnel_cfg.gro_complete = vxlan_gro_complete;
|
||||
}
|
||||
|
||||
setup_udp_tunnel_sock(net, sock, &tunnel_cfg);
|
||||
setup_udp_tunnel_sock(net, sock->sk, &tunnel_cfg);
|
||||
|
||||
return vs;
|
||||
}
|
||||
|
||||
@@ -389,7 +389,7 @@ int wg_socket_init(struct wg_device *wg, u16 port)
|
||||
goto out;
|
||||
}
|
||||
set_sock_opts(new4);
|
||||
setup_udp_tunnel_sock(net, new4, &cfg);
|
||||
setup_udp_tunnel_sock(net, new4->sk, &cfg);
|
||||
|
||||
#if IS_ENABLED(CONFIG_IPV6)
|
||||
if (ipv6_mod_enabled()) {
|
||||
@@ -404,7 +404,7 @@ int wg_socket_init(struct wg_device *wg, u16 port)
|
||||
goto out;
|
||||
}
|
||||
set_sock_opts(new6);
|
||||
setup_udp_tunnel_sock(net, new6, &cfg);
|
||||
setup_udp_tunnel_sock(net, new6->sk, &cfg);
|
||||
}
|
||||
#endif
|
||||
|
||||
|
||||
@@ -94,7 +94,7 @@ struct udp_tunnel_sock_cfg {
|
||||
};
|
||||
|
||||
/* Setup the given (UDP) sock to receive UDP encapsulated packets */
|
||||
void setup_udp_tunnel_sock(struct net *net, struct socket *sock,
|
||||
void setup_udp_tunnel_sock(struct net *net, struct sock *sk,
|
||||
struct udp_tunnel_sock_cfg *sock_cfg);
|
||||
|
||||
/* -- List of parsable UDP tunnel types --
|
||||
|
||||
@@ -615,7 +615,7 @@ static int fou_create(struct net *net, struct fou_cfg *cfg,
|
||||
goto error;
|
||||
}
|
||||
|
||||
setup_udp_tunnel_sock(net, sock, &tunnel_cfg);
|
||||
setup_udp_tunnel_sock(net, sk, &tunnel_cfg);
|
||||
|
||||
sk->sk_allocation = GFP_ATOMIC;
|
||||
|
||||
|
||||
@@ -68,11 +68,9 @@ static bool sk_saddr_any(struct sock *sk)
|
||||
#endif
|
||||
}
|
||||
|
||||
void setup_udp_tunnel_sock(struct net *net, struct socket *sock,
|
||||
void setup_udp_tunnel_sock(struct net *net, struct sock *sk,
|
||||
struct udp_tunnel_sock_cfg *cfg)
|
||||
{
|
||||
struct sock *sk = sock->sk;
|
||||
|
||||
/* Disable multicast loopback */
|
||||
inet_clear_bit(MC_LOOP, sk);
|
||||
|
||||
|
||||
@@ -1683,7 +1683,7 @@ int l2tp_tunnel_register(struct l2tp_tunnel *tunnel, struct net *net,
|
||||
.encap_destroy = l2tp_udp_encap_destroy,
|
||||
};
|
||||
|
||||
setup_udp_tunnel_sock(net, sock, &udp_cfg);
|
||||
setup_udp_tunnel_sock(net, sock->sk, &udp_cfg);
|
||||
}
|
||||
|
||||
sk->sk_allocation = GFP_ATOMIC;
|
||||
|
||||
@@ -194,7 +194,7 @@ static int rxrpc_open_socket(struct rxrpc_local *local, struct net *net)
|
||||
tuncfg.encap_rcv = rxrpc_encap_rcv;
|
||||
tuncfg.encap_err_rcv = rxrpc_encap_err_rcv;
|
||||
tuncfg.sk_user_data = local;
|
||||
setup_udp_tunnel_sock(net, local->socket, &tuncfg);
|
||||
setup_udp_tunnel_sock(net, local->socket->sk, &tuncfg);
|
||||
|
||||
/* set the socket up */
|
||||
usk = local->socket->sk;
|
||||
|
||||
@@ -864,7 +864,7 @@ int sctp_udp_sock_start(struct net *net)
|
||||
tuncfg.encap_type = 1;
|
||||
tuncfg.encap_rcv = sctp_udp_rcv;
|
||||
tuncfg.encap_err_lookup = sctp_udp_v4_err;
|
||||
setup_udp_tunnel_sock(net, sock, &tuncfg);
|
||||
setup_udp_tunnel_sock(net, sock->sk, &tuncfg);
|
||||
net->sctp.udp4_sock = sock->sk;
|
||||
|
||||
#if IS_ENABLED(CONFIG_IPV6)
|
||||
@@ -886,7 +886,7 @@ int sctp_udp_sock_start(struct net *net)
|
||||
tuncfg.encap_type = 1;
|
||||
tuncfg.encap_rcv = sctp_udp_rcv;
|
||||
tuncfg.encap_err_lookup = sctp_udp_v6_err;
|
||||
setup_udp_tunnel_sock(net, sock, &tuncfg);
|
||||
setup_udp_tunnel_sock(net, sock->sk, &tuncfg);
|
||||
net->sctp.udp6_sock = sock->sk;
|
||||
#endif
|
||||
|
||||
|
||||
@@ -771,7 +771,7 @@ static int tipc_udp_enable(struct net *net, struct tipc_bearer *b,
|
||||
tuncfg.encap_type = 1;
|
||||
tuncfg.encap_rcv = tipc_udp_recv;
|
||||
tuncfg.encap_destroy = NULL;
|
||||
setup_udp_tunnel_sock(net, ub->ubsock, &tuncfg);
|
||||
setup_udp_tunnel_sock(net, ub->ubsock->sk, &tuncfg);
|
||||
|
||||
err = dst_cache_init(&ub->rcast.dst_cache, GFP_ATOMIC);
|
||||
if (err)
|
||||
|
||||
Reference in New Issue
Block a user