mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-12-28 10:15:32 -05:00
MIPS: octeon: Replace memset(0) + deprecated strcpy() with strscpy_pad()
Replace memset(0) followed by the deprecated strcpy() with strscpy_pad() to improve octeon_fdt_set_phy(). This avoids zeroing the memory before copying the string and ensures the destination buffer is only written to once, simplifying the code and improving efficiency. Link: https://github.com/KSPP/linux/issues/88 Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> Reviewed-by: Justin Stitt <justinstitt@google.com> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
This commit is contained in:
committed by
Thomas Bogendoerfer
parent
267ac0a800
commit
2c7c8cf656
@@ -13,6 +13,7 @@
|
||||
#include <linux/of_fdt.h>
|
||||
#include <linux/platform_device.h>
|
||||
#include <linux/libfdt.h>
|
||||
#include <linux/string.h>
|
||||
|
||||
#include <asm/octeon/octeon.h>
|
||||
#include <asm/octeon/cvmx-helper-board.h>
|
||||
@@ -538,8 +539,7 @@ static void __init octeon_fdt_set_phy(int eth, int phy_addr)
|
||||
|
||||
if (octeon_has_88e1145()) {
|
||||
fdt_nop_property(initial_boot_params, phy, "marvell,reg-init");
|
||||
memset(new_name, 0, sizeof(new_name));
|
||||
strcpy(new_name, "marvell,88e1145");
|
||||
strscpy_pad(new_name, "marvell,88e1145");
|
||||
p = fdt_getprop(initial_boot_params, phy, "compatible",
|
||||
¤t_len);
|
||||
if (p && current_len >= strlen(new_name))
|
||||
|
||||
Reference in New Issue
Block a user