mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-12-27 10:01:39 -05:00
media: mn88443x: Use %pe format specifier
The %pe format specifier is designed to print error pointers. It prints a symbolic error name (eg. -EINVAL) and it makes the code simpler by omitting PTR_ERR() This patch fixes this cocci report: ./dvb-frontends/mn88443x.c:698:3-10: WARNING: Consider using %pe to print PTR_ERR() ./dvb-frontends/mn88443x.c:713:3-10: WARNING: Consider using %pe to print PTR_ERR() Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
This commit is contained in:
committed by
Hans Verkuil
parent
f6493b5297
commit
283ea98f2a
@@ -694,8 +694,7 @@ static int mn88443x_probe(struct i2c_client *client)
|
||||
|
||||
chip->mclk = devm_clk_get(dev, "mclk");
|
||||
if (IS_ERR(chip->mclk) && !conf) {
|
||||
dev_err(dev, "Failed to request mclk: %ld\n",
|
||||
PTR_ERR(chip->mclk));
|
||||
dev_err(dev, "Failed to request mclk: %pe\n", chip->mclk);
|
||||
return PTR_ERR(chip->mclk);
|
||||
}
|
||||
|
||||
@@ -709,8 +708,8 @@ static int mn88443x_probe(struct i2c_client *client)
|
||||
chip->reset_gpio = devm_gpiod_get_optional(dev, "reset",
|
||||
GPIOD_OUT_HIGH);
|
||||
if (IS_ERR(chip->reset_gpio)) {
|
||||
dev_err(dev, "Failed to request reset_gpio: %ld\n",
|
||||
PTR_ERR(chip->reset_gpio));
|
||||
dev_err(dev, "Failed to request reset_gpio: %pe\n",
|
||||
chip->reset_gpio);
|
||||
return PTR_ERR(chip->reset_gpio);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user