mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-07 10:24:01 -04:00
Code Issues Packages Projects Releases Wiki Activity

Staging: ipack/bridges/tpci200: fix kernel oops when uninstalling a device

Browse Source 
When uninstalling a device, the call to the ipack_bus_ops remove() frees
resources in the ipack device driver but without unregistering the device.

It generates a kernel oops when somebody wants to unregister the device.

Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Samuel Iglesias Gonsalvez
2012-05-25 10:03:05 +02:00
committed by Greg Kroah-Hartman
parent ca2d2bb661
commit 20cf700824
1 changed files with 1 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/staging/ipack/bridges/tpci200.c
View File

@@ -751,23 +751,12 @@ static int tpci200_request_irq(struct ipack_device *dev, int vector,
return res;
}
static void tpci200_slot_remove(struct tpci200_slot *slot)
{
if ((slot->dev == NULL) ||
(slot->dev->driver == NULL) ||
(slot->dev->driver->ops == NULL) ||
(slot->dev->driver->ops->remove == NULL))
return;
slot->dev->driver->ops->remove(slot->dev);
}
static void tpci200_uninstall(struct tpci200_board *tpci200)
{
int i;
for (i = 0; i < TPCI200_NB_SLOT; i++)
tpci200_slot_remove(&tpci200->slots[i]);
tpci200_slot_unregister(tpci200->slots[i].dev);
tpci200_unregister(tpci200);
kfree(tpci200->slots);