mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-05-09 04:21:03 -04:00
staging: comedi: usbduxsigma: remove tidy_up() from (*auto_attach)
Comedi drivers do not need to cleanup allocations during the (*auto_attach). If the (*auto_attach) fails the (*detach) will automatically be called to handle the cleanup. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
9838f532dc
commit
1fc56e86e4
@@ -1834,10 +1834,8 @@ static int usbduxsigma_auto_attach(struct comedi_device *dev,
|
||||
}
|
||||
|
||||
ret = usbduxsigma_alloc_usb_buffers(dev);
|
||||
if (ret) {
|
||||
tidy_up(devpriv);
|
||||
if (ret)
|
||||
return ret;
|
||||
}
|
||||
|
||||
ret = comedi_load_firmware(dev, &usb->dev, FIRMWARE,
|
||||
usbduxsigma_firmware_upload, 0);
|
||||
|
||||
Reference in New Issue
Block a user