mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-08-31 05:49:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

pinctrl: Remove redundant dev_err()/dev_err_probe()

Browse Source 
Since commit 55b48e23f5 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() and dev_err_probe() calls.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
Signed-off-by: Linus Walleij <linusw@kernel.org>
This commit is contained in:
Pan Chuang
2026-07-17 18:58:46 +08:00
committed by Linus Walleij
parent ee88f84f95
commit 17015f70fb
3 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/pinctrl/pinctrl-aw9523.c
View File

@@ -817,7 +817,7 @@ static int aw9523_init_irq(struct aw9523 *awi, int irq)
ret = devm_request_threaded_irq(dev, irq, NULL, aw9523_irq_thread_func,
IRQF_ONESHOT, dev_name(dev), awi);
if (ret)
return dev_err_probe(dev, ret, "Failed to request irq %d\n", irq);
return ret;
girq = &awi->gpio.irq;
gpio_irq_chip_set_chip(girq, &aw9523_irq_chip);

5
drivers/pinctrl/pinctrl-mcp23s08.c
View File

@@ -560,11 +560,8 @@ static int mcp23s08_irq_setup(struct mcp23s08 *mcp)
err = devm_request_threaded_irq(chip->parent, mcp->irq, NULL,
mcp23s08_irq,
irqflags, dev_name(chip->parent), mcp);
if (err != 0) {
dev_err(chip->parent, "unable to request IRQ#%d: %d\n",
mcp->irq, err);
if (err)
return err;
}
return 0;
}

4
drivers/pinctrl/pinctrl-stmfx.c
View File

@@ -727,10 +727,8 @@ static int stmfx_pinctrl_probe(struct platform_device *pdev)
stmfx_pinctrl_irq_thread_fn,
IRQF_ONESHOT,
dev_name(pctl->dev), pctl);
if (ret) {
dev_err(pctl->dev, "cannot request irq%d\n", irq);
if (ret)
return ret;
}
dev_info(pctl->dev,
"%ld GPIOs available\n", hweight_long(pctl->gpio_valid_mask));